Executor with custom S3 doesn't work in appwrite 1.9.5 (executor 0.25.1)

Was testing to upgrade appwrite to 1.9.5 and when testing the S3 part i saw the executor didn't work anymore. When looking closly i saw the StorageFactory doesn't provide the bucket anymore.

I opened an issue in the executor project : https://github.com/open-runtimes/executor/issues/239

Executor with custom S3 doesn't work in appwrite 1.9.5 (0.25.1)

Executor with custom S3 doesn't work in appwrite 1.9.5 (executor 0.25.1)

same issue

since the issue include everything i made an override compose for that part so using the yaml file and using docker compose -f docker-compose.yml -f docker-compose.executor-s3-hotfix.override.yml up -d it should fix the openruntimes-executor (check the comment there is an env to add/change)

@darkmess if you want to test it

@Ibaraki Douji https://github.com/open-runtimes/executor/pull/242

I still have this issue in 1.9.6

do you confirm your executor have the S3 URL like this ? :

where :

• key is your Access Key
• secret is your Secret Key
• region is the S3 region
• url-encoded-s3-endpoint is your s3 url but encoded like https%3A%2F%2Fs3.example.com

also 1.9.6 uses openruntimes/executor:0.25.4 is it that one that your using with 1.9.6 and not 0.25.1 ?

yes the version is openruntimes/executor:0.25.4. How do I check the executor url?

docker ps | grep executor
then
docker inspect <container_name> | grep OPR_EXECUTOR_CONNECTION_STORAGE

I don’t have the OPR_EXECUTOR_CONNECTION_STORAGE env variable set anywhere. Is this now required to make it work with S3? I downloaded the compose and .env files from the installation page and they do not contain that variable

iirc, they don't document S3 setups for SH
but it's there : https://github.com/open-runtimes/executor/blob/main/src/Executor/Runner/Docker.php#L293

and yes required, it replace the old OPR_EXECUTOR_STORAGE.... for the S3 connection

Thank you. I finally got it working

@Chirag Aggarwal would it be possible to document that env somewhere ? (like adding an executor s3 connection in the .env and pass it to the compose, and maybe on the website as well)

might be, up for a challenge? i can review ur pr

why not, tho for the website i don't really know svelte so i prefer letting someone do that part.

its just docs, shouldnt be hard

ye but if i start the website part i will also want to make a complete S3 doc for SH ..

Issue : https://github.com/appwrite/appwrite/issues/13057
PR : https://github.com/appwrite/appwrite/pull/13059

merge conflict

bruh i pulled everything before xdd
will check what the backend is, tho i think i will do "accept both"

also do check greptile, might be valid?